Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds proper error handling for HTTP 404 responses in the Tower CLI, allowing operations like deleting non-existent apps to return graceful error messages instead of "crash"-type responses.
- Adds a specific case for
StatusCode::NOT_FOUNDin the error handling match statement - Uses
output_full_error_detailsto provide detailed error information for 404 responses
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
socksy
approved these changes
Sep 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of our operations that are not fulfilled for legitimate reasons but don't crash, return a "crash"-type of response to the CLI.
One such case is 404 e.g. deleting an app that doesn't exist.
Adding the case to handle those